Conversation
Deploying rnet with
|
| Latest commit: |
48faf3b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a7043850.rnet-7tt.pages.dev |
| Branch Preview URL: | https://perf.rnet-7tt.pages.dev |
This comment was marked as outdated.
This comment was marked as outdated.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the asynchronous context management (__aenter__/__aexit__) to use native async functions provided by pyo3. This is a great improvement as it simplifies the code, makes it more idiomatic, and should improve performance by reducing overhead. The AllowThreads utility has also been aptly renamed to NoGIL to better reflect its function of releasing the Global Interpreter Lock. The changes are consistent across the codebase. I've left one minor suggestion for code simplification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.