perf(stream): refactor Streamer for compatibility with frozen async state

[0x676e67]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @0x676e67, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Streamer class to ensure compatibility with Python's frozen async state. The primary changes involve marking the class as frozen and adjusting its asynchronous iteration methods to operate on immutable references, thereby preventing unintended mutations and aligning with the principles of frozen objects. This enhances the robustness and predictability of stream handling in an asynchronous context.

Highlights

• Frozen Class Compatibility: The Streamer class is now marked as frozen in its pyclass definition, enabling compatibility with Python's frozen async state.
• Immutable Async Methods: The __next__ and __anext__ methods were updated to take an immutable reference (&self) instead of a mutable one (&mut self), aligning with the frozen class behavior.
• Async Method Refactoring: Asynchronous dunder methods (__aiter__, __anext__, __aenter__) were refactored into a dedicated #[pymethods] block, likely to better support the frozen attribute and maintain immutability.

Changelog

• src/client/body/stream.rs
  • Added the frozen attribute to the #[pyclass] macro for the Streamer struct.
  • Modified the __next__ method signature from &mut self to &self.
  • Moved the __aiter__, __anext__, and __aenter__ methods from the main impl Streamer block to a new #[pymethods] impl Streamer block.
  • Updated the variable name a to resp within the __aexit__ method for improved readability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[cloudflare-workers-and-pages]

Deploying rnet with    Cloudflare Pages

Latest commit:	fee11f9
Status:	✅  Deploy successful!
Preview URL:	https://7c506677.rnet-7tt.pages.dev
Branch Preview URL:	https://stream.rnet-7tt.pages.dev

View logs

[gemini-code-assist]

Code Review

This pull request refactors the Streamer struct to be compatible with Python's frozen objects by marking it with #[pyclass(frozen)]. This is a great change for ensuring immutability from the Python side. The necessary adjustments, such as changing &mut self to &self in __next__ and __anext__ and relying on interior mutability with Arc<Mutex<...>>, have been correctly implemented. The methods have also been reorganized into separate #[pymethods] blocks for synchronous and asynchronous operations, which improves code clarity. The changes are well-executed and improve the robustness of the code.