Skip to content

feat(response): clear cached data when response is dropped#535

Merged
0x676e67 merged 1 commit intomainfrom
drop
Mar 14, 2026
Merged

feat(response): clear cached data when response is dropped#535
0x676e67 merged 1 commit intomainfrom
drop

Conversation

@0x676e67
Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances resource management by ensuring that cached response data is explicitly cleared when Response and BlockingResponse objects are no longer needed. This change introduces a dedicated destroy method and integrates it with the Drop trait and existing close functionalities, thereby improving memory hygiene. Additionally, it includes minor refactoring of import statements to streamline code organization.

Highlights

  • Resource Management: Implemented the Drop trait for Response and BlockingResponse to ensure cached data is cleared when these objects go out of scope, preventing potential memory leaks.
  • New destroy method: Introduced a destroy method to Response which forcefully clears the response body, and updated existing close methods to utilize this new mechanism.
  • Data Cloning: Modified the conversion of Response to wreq::Response to explicitly clone headers and extensions, ensuring data integrity.
  • Code Organization: Refactored use statements in src/lib.rs for improved readability and consistency.
Changelog
  • src/client/resp/http.rs
    • Implemented Drop trait for Response to call self.destroy().
    • Implemented Drop trait for BlockingResponse to call self.0.destroy().
    • Added a new private destroy method to Response to clear the body.
    • Updated close methods in Response and BlockingResponse to use the new destroy method.
    • Modified headers_mut() and extensions_mut() assignments to use .clone() when converting Response to wreq::Response.
  • src/lib.rs
    • Refactored use statements in the r#async module for better grouping.
    • Refactored use statements in the blocking module for better grouping.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot]

This comment was marked as spam.

@0x676e67 0x676e67 merged commit c65346e into main Mar 14, 2026
32 checks passed
@0x676e67 0x676e67 deleted the drop branch March 14, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant