refactor: standardize TLS config fields with tls_ prefix#548
Closed
joaquinhuigomez wants to merge 1 commit into0x676e67:mainfrom
Closed
refactor: standardize TLS config fields with tls_ prefix#548joaquinhuigomez wants to merge 1 commit into0x676e67:mainfrom
joaquinhuigomez wants to merge 1 commit into0x676e67:mainfrom
Conversation
Rename verify, verify_hostname, identity, and keylog to tls_verify, tls_verify_hostname, tls_identity, and tls_keylog for consistency with tls_info, min_tls_version, max_tls_version, and tls_options. Closes 0x676e67#545
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames several TLS-related configuration parameters to include a 'tls_' prefix, specifically updating 'verify', 'verify_hostname', 'identity', and 'keylog' to 'tls_verify', 'tls_verify_hostname', 'tls_identity', and 'tls_keylog' respectively. These changes are applied consistently across the Python type definitions, the Rust backend implementation, documentation, examples, and test suites. I have no feedback to provide.
Owner
|
AI bot？ |
joaquinhuigomez
temporarily deployed
to
MuslLinux
GitHub Actions
Inactive
joaquinhuigomez
temporarily deployed
to
MuslLinux
GitHub Actions
Inactive
joaquinhuigomez
temporarily deployed
to
MuslLinux
GitHub Actions
Inactive
joaquinhuigomez
temporarily deployed
to
MuslLinux
GitHub Actions
Inactive
joaquinhuigomez
temporarily deployed
to
MuslLinux
GitHub Actions
Inactive
joaquinhuigomez
temporarily deployed
to
MuslLinux
GitHub Actions
Inactive
joaquinhuigomez
temporarily deployed
to
MuslLinux
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
verify,verify_hostname,identity, andkeylogtotls_verify,tls_verify_hostname,tls_identity, andtls_keylogfor consistency with the existingtls_info,min_tls_version,max_tls_version, andtls_optionsfields.Changes across
src/client.rs,python/wreq/wreq.py,tests/tls_test.py,examples/, anddocs/.Closes #545