Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to handle the maximum number of redirects in HTTP requests. The changes span across multiple files, including both Python interface definitions and Rust implementation files.
Key Changes:
Python Interface Updates:
rnet.pyi: Addedmax_redirectsas an optional integer parameter to bothClientParamsandRequestParamsclasses. [1] [2]Rust Implementation Updates:
src/client.rs: Updated theClientandexecute_requestfunctions to use the newmax_redirectsparameter, applying a limited policy if specified. [1] [2]src/param/client.rs: Addedmax_redirectsas an optional field in theClientParamsstruct, with documentation.src/param/request.rs: Addedmax_redirectsas an optional field in theRequestParamsstruct, with documentation, and updated theFromPyObjectimplementation to extract this new parameter. [1] [2]