Skip to content

Add overrides to isolated pnpm lockfile #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Add overrides to isolated pnpm lockfile #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebfb7f5
Copy pnpm overrides back into pruned lockfile
0x80 May 21, 2024
ddc1b4a
1.17.0-0
0x80 May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "isolate-package",
"version": "1.16.0",
"version": "1.17.0-0",
"description": "Isolate a monorepo package with its shared dependencies to form a self-contained directory, compatible with Firebase deploy",
"author": "Thijs Koerselman",
"license": "MIT",
Expand Down
5 changes: 5 additions & 0 deletions src/lib/lockfile/helpers/generate-pnpm-lockfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ export async function generatePnpmLockfile({
? await pruneLockfile_v9(lockfile, targetPackageManifest, ".")
: await pruneLockfile_v8(lockfile, targetPackageManifest, ".");

/** Pruning seems to remove the overrides from the lockfile */
if (lockfile.overrides) {
prunedLockfile.overrides = lockfile.overrides;
}

/**
* Don't know how to map the patched dependencies yet, so we just include
* them but I don't think it would work like this. The important thing for
Expand Down