Investigate nginx-ui issue 1446 #1447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that when a site's health check is disabled, the checker returns cached metadata without making any network requests, as per issue #1446. A new helper function `getExistingSiteSnapshot` is introduced to retrieve this cached information. A new test case `TestCheckSiteSkipsNetworkWhenDisabled` is added to verify this behavior. Co-authored-by: jacky-943572677 <jacky-943572677@qq.com>
|
Cursor Agent can help with this pull request. Just |
Owner
Author
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent disabled site health checks from making network requests to fix issue #1446.
Even when health checks were disabled, the
tryGetFaviconfunction would implicitly trigger HTTP GET requests, leading to unexpected traffic. This PR ensures that when health checks are disabled, cached site metadata is returned immediately without any network activity.Note
When health checks are disabled, return cached site metadata without making HTTP requests, leveraging a snapshot of prior site info and adding a unit test to enforce this.
CheckSitenow returns cached metadata whenHealthCheckEnabledis false, avoiding favicon fetches and all network calls; populates fields from an existing site snapshot if available.getExistingSiteSnapshotwith read-locking to safely clone priorSiteInfo.TestCheckSiteSkipsNetworkWhenDisabledto ensure no HTTP requests occur when health checks are disabled.Written by Cursor Bugbot for commit 54d2764. This will update automatically on new commits. Configure here.