feat: allow full HTTP status codes for health checks #1458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jacky-943572677 <jacky-943572677@qq.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: jacky-943572677 <jacky-943572677@qq.com>
Co-authored-by: jacky-943572677 <jacky-943572677@qq.com>
0xJacky
changed the title
Co-authored-by: jacky-943572677 <jacky-943572677@qq.com>
Owner
Author
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
0xJacky
added a commit
that referenced
this pull request
Nov 28, 2025
* Add 401 Unauthorized to SiteHealthCheckModal status codes Co-authored-by: jacky-943572677 <jacky-943572677@qq.com> * Checkpoint before follow-up message Co-authored-by: jacky-943572677 <jacky-943572677@qq.com> * Refactor status code selection to use grouped options Co-authored-by: jacky-943572677 <jacky-943572677@qq.com> * Fix: Correct apostrophe in "I'm a teapot" status Co-authored-by: jacky-943572677 <jacky-943572677@qq.com> --------- Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
401 Unauthorizedto the health check's expected status codes dropdown.This allows sites requiring authentication to correctly configure
401 Unauthorizedas an expected status, preventing them from being mistakenly flagged as unhealthy.Note
Expands the health check "Expected Status Codes" dropdown to include all grouped HTTP 1xx–5xx codes, replacing hardcoded options.
app/src/views/dashboard/components/SiteHealthCheckModal.vue:StatusCodeOption/StatusCodeGroupinterfaces andcreateStatusOptionhelper; define grouped status lists for 1xx–5xx.ASelectOptions with grouped options usingASelectOptGroupandv-forto render all HTTP codes.Written by Cursor Bugbot for commit c4e1bee. This will update automatically on new commits. Configure here.