Skip to content

Conversation

@0xJacky
Copy link
Owner

@0xJacky 0xJacky commented Mar 31, 2025

Close #914

@0xJacky 0xJacky requested a review from Copilot March 31, 2025 02:45
@0xJacky 0xJacky marked this pull request as ready for review March 31, 2025 02:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces HTTPS support by adding new error messages, configuration fields, and SSL certificate validations while also making minor adjustments to component prop types.

  • Added HTTPS-related error codes and messages in the constants files
  • Updated server settings to include HTTPS configuration and SSL paths
  • Adjusted SSL validation logic and introduced a restart mechanism following HTTPS changes

Reviewed Changes

Copilot reviewed 25 out of 40 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/src/constants/errors/system.ts Added new error messages for missing or invalid SSL certificate/key settings
app/src/constants/errors/middleware.ts Added a new error message for a form parsing failure
app/src/components/Chart/UsageProgressLine.vue Made the 'percent' prop optional, defaulting to 0 if undefined
app/src/api/settings.ts Introduced new HTTPS-related settings fields in ServerSettings and NodeSettings
api/settings/settings.go Implemented SSL certificate validation and asynchronous restart logic when HTTPS settings change
Files not reviewed (15)
  • .vscode/tasks.json: Language not supported
  • app/package.json: Language not supported
  • app/src/language/ar/app.po: Language not supported
  • app/src/language/de_DE/app.po: Language not supported
  • app/src/language/en/app.po: Language not supported
  • app/src/language/es/app.po: Language not supported
  • app/src/language/fr_FR/app.po: Language not supported
  • app/src/language/ko_KR/app.po: Language not supported
  • app/src/language/messages.pot: Language not supported
  • app/src/language/ru_RU/app.po: Language not supported
  • app/src/language/tr_TR/app.po: Language not supported
  • app/src/language/vi_VN/app.po: Language not supported
  • app/src/language/zh_CN/app.po: Language not supported
  • app/src/language/zh_TW/app.po: Language not supported
  • app/src/version.json: Language not supported
Comments suppressed due to low confidence (2)

app/src/components/Chart/UsageProgressLine.vue:5

  • Ensure that all consumers of UsageProgressLine properly handle the optional 'percent' prop now that it can be undefined.
percent?: number

api/settings/settings.go:86

  • Consider adding test cases to cover the SSL certificate validation logic when HTTPS is enabled to ensure robust handling of SSL configuration changes.
// Validate SSL certificates if HTTPS is enabled

@0xJacky 0xJacky merged commit 5b8657d into dev Mar 31, 2025
19 checks passed
@0xJacky 0xJacky deleted the feat/https branch April 2, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

默认http 9000端口 请问如何开启https

2 participants