feat(logging): unified log levels, Redact via LogValuer, CLI flag, settings migration#19
Merged
feat(logging): unified log levels, Redact via LogValuer, CLI flag, settings migration#19
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tegy Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…agging Replace bool-based Init(enabled, sensitive) with Init(level, sensitive) accepting "trace", "debug", "info", "warning", "error", or "off". Add custom TRACE level, Redact() wrapping values as slog.LogValuer for safe redaction, FrontendLogger() with source=frontend tagging, and 14 tests covering level filtering, redaction, and source tagging. Backward-compatible Sensitive() retained for Task 5 migration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…r, update spec Addresses code review: sensitiveEnabled is now goroutine-safe via sync/atomic. Extracted duplicate replaceAttr lambda to package-level function. Updated spec to document that error/warn frontend messages are not redacted. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
debug_loggingtoggle with six-level system: off, trace, debug, info, warning, errorRedact()wraps values withslog.LogValuer— shows[redacted]when sensitive logging is off, real value when on. Removes standaloneSensitive()functionsource=backendorsource=frontendfor easy filtering--log <level>flag on both-fixand-pyramidizecommands (sensitive always off in CLI)debug_logging: trueauto-migrates tolog_level: "debug"on loadsensitiveEnabledusesatomic.Boolfor goroutine-safe reads during log callsdocs/logging.mdwith conventions (Redact usage, source tagging, CLI flags)Closes #2
Test plan
build-linux.ymlCI will run automatically.Generated with Claude Code