Node startup script not working

[SantiagoPittella]

I was just testing next node's startup and noticed that the run-node.sh is not working.

I ran:

make install-validator
make install-node
./scripts/run-node.sh

And this is the output:

=== Killing processes on required ports ===
=== Skipping bootstrap (SKIP_BOOTSTRAP=true) ===
=== Starting components ===
Starting store (block-producer mode)...
Starting validator...
scripts/run-node.sh: line 124: ./target/debug/miden-validator: No such file or directory
error: unexpected argument '--rpc.listen' found

  tip: a similar argument exists: '--rpc.url'

Usage: miden-node store start --rpc.url <URL> --ntx-builder.url <URL> --block-producer.url <URL> --data-directory <DIR>

For more information, try '--help'.
Starting store replica 1 (upstream: primary store at 127.0.0.1:50001)...
Starting store replica 2 (upstream: replica 1 at 127.0.0.1:50011)...
Starting block producer...
Starting RPC server (primary store)...
Starting RPC server (replica 1)...
Starting RPC server (replica 2)...
Starting network transaction builder...
=== All components running. Ctrl+C to stop. ===
=== Block propagation chain: :50001 -> :50011 -> :50021 ===
=== RPC endpoints: :57291, :57292, :57293 ===
scripts/run-node.sh: line 179: ./target/debug/miden-ntx-builder: No such file or directory
error: unrecognized subcommand 'start-replica'

  tip: a similar subcommand exists: 'start'

Usage: miden-node store <COMMAND>

For more information, try '--help'.
error: unrecognized subcommand 'start-replica'

  tip: a similar subcommand exists: 'start'

Usage: miden-node store <COMMAND>

For more information, try '--help'.
error: unexpected argument '--listen' found

  tip: to pass '--listen' as a value, use '-- --listen'

Usage: miden-node block-producer start [OPTIONS] --store.url <STORE_URL> --validator.url <VALIDATOR_URL> <URL>

For more information, try '--help'.
error: unexpected argument '--listen' found

Usage: miden-node rpc start [OPTIONS] --url <URL> --store.url <URL> --validator.url <URL>

For more information, try '--help'.
error: unexpected argument '--listen' found

Usage: miden-node rpc start [OPTIONS] --url <URL> --store.url <URL> --validator.url <URL>

For more information, try '--help'.
error: unexpected argument '--listen' found

Usage: miden-node rpc start [OPTIONS] --url <URL> --store.url <URL> --validator.url <URL>

For more information, try '--help'.
Shutting down...
All components stopped.

Also, recently I noticed that the validator bootstrap appears to be missing a dir to ensure that exists and its clean. I think we need:

diff --git a/bin/validator/src/commands/bootstrap.rs b/bin/validator/src/commands/bootstrap.rs
index 011eb42d..28a9775c 100644
--- a/bin/validator/src/commands/bootstrap.rs
+++ b/bin/validator/src/commands/bootstrap.rs
@@ -27,7 +27,7 @@ pub async fn bootstrap(
         .transpose()?
         .unwrap_or_default();

-    for directory in [accounts_directory, genesis_block_directory] {
+    for directory in [accounts_directory, genesis_block_directory, data_directory] {
         ensure_empty_directory(directory)?;
     }

[Mr-kay-cloud2]

I’d like to work on this. I’ll start by applying the validator bootstrap directory cleanup fix, then inspect the current CLI command names/flags and update scripts/run-node.sh accordingly.