feat: add a genesis configuration toml file#1000
Merged
Conversation
drahnr
force-pushed
the
bernhard-toml-genesis
branch
from
26e24eb to
8af5e8c
Compare
drahnr
force-pushed
the
bernhard-toml-genesis
branch
2 times, most recently
from
c831161 to
f00946f
Compare
mmagician
reviewed
Jun 26, 2025
sergerad
reviewed
Jun 26, 2025
sergerad
reviewed
Jun 26, 2025
sergerad
reviewed
Jun 26, 2025
sergerad
reviewed
Jun 26, 2025
drahnr
force-pushed
the
bernhard-toml-genesis
branch
2 times, most recently
from
2744435 to
92d9d22
Compare
Mirko-von-Leipzig
approved these changes
Jun 30, 2025
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
I think we still need to integrate this with the CLI of the node. That could also be a separate PR?
Mirko-von-Leipzig
requested changes
Jun 30, 2025
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Didn't mean to approve just yet :)
drahnr
commented
Jun 30, 2025
mmagician
requested changes
Jul 1, 2025
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Some doc suggestions and questions :)
mmagician
reviewed
Jul 3, 2025
mmagician
reviewed
Jul 3, 2025
Contributor
mmagician
left a comment
mmagician
left a comment
There was a problem hiding this comment.
I'm looking forward to using this for integration testing, thanks. I left a few minor comments but functionality-wise looks good 👍🏼
mmagician
requested changes
Jul 3, 2025
sergerad
reviewed
Jul 4, 2025
sergerad
reviewed
Jul 4, 2025
drahnr
changed the title
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
drahnr
force-pushed
the
bernhard-toml-genesis
branch
from
4298370 to
6c9ad51
Compare
drahnr
force-pushed
the
bernhard-toml-genesis
branch
from
740891d to
4791086
Compare
Contributor
Author
|
|
drahnr
commented
Jul 9, 2025
bobbinth
approved these changes
Jul 10, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
All looks good! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #836
Superseeds: mmagician#1