chore(remote-prover): rename proving-service to remote-prover#1004
Merged
SantiagoPittella merged 11 commits intonextfrom Jun 30, 2025
Merged
chore(remote-prover): rename proving-service to remote-prover#1004SantiagoPittella merged 11 commits intonextfrom
SantiagoPittella merged 11 commits intonextfrom
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-rename-proving-service
branch
from
150bbe6 to
1c26153
Compare
SantiagoPittella
force-pushed
the
santiagopittella-rename-proving-service
branch
from
1c26153 to
de7f35b
Compare
SantiagoPittella
requested review from
Mirko-von-Leipzig,
bobbinth,
igamigo and
sergerad
and removed request for
Mirko-von-Leipzig
sergerad
reviewed
Jun 24, 2025
CHANGELOG.md
Outdated
| - Added support for TLS to faucet's connection to node RPC (#976). | ||
| - Replaced integer-based duration args with human-readable duration strings (#998). | ||
| - [BREAKING] Refactor the `miden-proving-service` proxy status service to use gRPC instead of HTTP (#953). | ||
| - [BREAKING] Refactor the `miden-remote-prover` proxy status service to use gRPC instead of HTTP (#953). |
Collaborator
There was a problem hiding this comment.
The changelog shouldn't modify existing references to miden-proving-service. And should specify the change of name done by this PR (understand you are aware of this just probably overlooked these diffs given how many there are).
sergerad
requested changes
Jun 24, 2025
Collaborator
sergerad
left a comment
sergerad
left a comment
There was a problem hiding this comment.
Thanks, looks good. Just the changelog comment and the ProvingServiceError:
sergerad
approved these changes
Jun 26, 2025
bobbinth
reviewed
Jun 27, 2025
bobbinth
approved these changes
Jun 27, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I added a couple of small comments inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #941