Merged
Conversation
drahnr
force-pushed
the
bernhard-616-drop-get-acc-state-delta
branch
from
836c3a4 to
5fd9ea9
Compare
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Changes look good; but I'll let @igamigo confirm whether he doesn't need some of this data for his work on state sync.
igamigo
approved these changes
Aug 20, 2025
bobbinth
approved these changes
Aug 20, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left one small comment inline.
Closed
JereSalo
added a commit
to 0xMiden/miden-client
that referenced
this pull request
Feb 3, 2026
The GetAccountStateDelta RPC endpoint was removed from the node in 0xMiden/node#1162 (Aug 2025). The generated proto code was correctly removed when updating the node dependency, but the NodeRpcClientEndpoint enum variant and documentation were left behind.
igamigo
pushed a commit
to 0xMiden/miden-client
that referenced
this pull request
Feb 3, 2026
* chore: remove stale GetAccountStateDelta endpoint reference The GetAccountStateDelta RPC endpoint was removed from the node in 0xMiden/node#1162 (Aug 2025). The generated proto code was correctly removed when updating the node dependency, but the NodeRpcClientEndpoint enum variant and documentation were left behind. * replace RPC endpoint list with link to node docs The hardcoded list was already out of sync with the node's actual endpoints. Linking to the authoritative source prevents future drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the first piece of #616
Closes #422 by removing the underlying API to change