chore: update base version without bech32 conversion#1172
Merged
Conversation
tomyrd
force-pushed
the
tomyrd-base-address
branch
from
13eb2c5 to
32e8c76
Compare
bobbinth
reviewed
Aug 22, 2025
tomyrd
changed the title
bobbinth
approved these changes
Aug 22, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
I think it is fine to remove the faucet at this point - so, I'm going to merge it.
This was referenced Aug 22, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
miden-baseversion to this PR so that the client an also be updated.These changes required updates in the
faucetbinary, which I wasn't sure if it was still being used after we moved it to a separate repository. For the moment I removed the binary, but if we want to keep it I can revert that change and update it accordingly.