Conversation
SantiagoPittella
added
the
no changelog
crates/utils/src/tracing/grpc.rs
Outdated
|
|
||
| // Extract the method name from the HTTP path (e.g., "/rpc.rpc/CheckNullifiers" -> | ||
| // "CheckNullifiers") | ||
| let method_name = request.uri().path().rsplit('/').next().unwrap_or("Unknown"); |
There was a problem hiding this comment.
Now that we are not doing an exhaustive match on the method, maybe we can just unwrap_or_default() and keep it empty?
crates/utils/src/tracing/grpc.rs
Outdated
|
|
||
| let span = add_otel_span_attributes(span, request); | ||
| add_network_attributes(span, request) | ||
| dynamic_trace_fn(request, TracedComponent::RemoteProverProxy) |
There was a problem hiding this comment.
Should we just call the dynamic fn in the services and get them to pass in the enum?
There was a problem hiding this comment.
We can simplify even further because the path also contains the service name, https://github.com/0xMiden/miden-node/pull/1206/files#r2320988255
crates/utils/src/tracing/grpc.rs
Outdated
|
|
||
| let span = add_otel_span_attributes(span, request); | ||
| add_network_attributes(span, request) | ||
| dynamic_trace_fn(request, TracedComponent::RemoteProverProxy) |
There was a problem hiding this comment.
We can simplify even further because the path also contains the service name, https://github.com/0xMiden/miden-node/pull/1206/files#r2320988255
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
We should simplify further as per #1206 (comment)
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Not a very in-depth review from me - but looks good! Thank you!
4 participants
closes #1198