chore: update miden-base to next#1215
Merged
Mirko-von-Leipzig merged 2 commits intonextfrom Sep 10, 2025
Merged
Conversation
tomyrd
added
the
no changelog
Mirko-von-Leipzig
approved these changes
Sep 10, 2025
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
@tomyrd Could you elaborate on this?
This is needed to suppress some compilation errors
Contributor
Author
Sure, I should've explained it better. The compilation errors were appearing in the client and were referencing code from the node. This probably happens because we import some of the node's crates. After these changes and pointing to this branch, they no longer appear. |
tomyrd
force-pushed
the
tomyrd-update-next
branch
from
001ef78 to
84aff9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the node's
miden-baseversion tonext. This is needed to suppress some compilation errors and also to advance this same version in the client.