fix: add env var to enable OTel in network monitor#1237
Merged
Conversation
SantiagoPittella
added
the
no changelog
sergerad
approved these changes
Sep 22, 2025
bobbinth
approved these changes
Sep 22, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left one question inline: if I understood correctly, we can currently enable OTEL via an environment variable, but not via CLI args - is this right? And if so, any reason not to make it so that it works with CLI args?
| const RPC_URL_ENV_VAR: &str = "MIDEN_MONITOR_RPC_URL"; | ||
| const REMOTE_PROVER_URLS_ENV_VAR: &str = "MIDEN_MONITOR_REMOTE_PROVER_URLS"; | ||
| const PORT_ENV_VAR: &str = "MIDEN_MONITOR_PORT"; | ||
| pub(crate) const ENABLE_OTEL_ENV_VAR: &str = "MIDEN_MONITOR_ENABLE_OTEL"; |
Contributor
There was a problem hiding this comment.
Is there a reason why we do not include this into the MonitorConfig struct?
Collaborator
Author
There was a problem hiding this comment.
I ended up including it in another PR since this was already merged 👌🏼
drahnr
pushed a commit
that referenced
this pull request
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new env var to enable OTel. The variable name is defined in the
status.rsfile, which doesn't make much sense. A newconfig.rsfile was created (along with the remote prover tests feature), and it is currently open for reviews here: #1236