Skip to content

chore: improve grpc spans#1274

Merged
bobbinth merged 3 commits intomainfrom
santiagopittella-fix-spans-main
Oct 9, 2025
Merged

chore: improve grpc spans#1274
bobbinth merged 3 commits intomainfrom
santiagopittella-fix-spans-main

Conversation

@SantiagoPittella
Copy link
Collaborator

@SantiagoPittella SantiagoPittella commented Oct 6, 2025

! WARNING: this PR aims to main

Copies the improved grpc spans handling from next to main.

@igamigo
Copy link
Collaborator

igamigo commented Oct 7, 2025

These are mainly changes from #1230, right? If so, would it make more sense to cherry pick the commit instead of creating a new one? This way you'd avoid (I think) the conflicts and the merge back to next later

@SantiagoPittella
feat: distributed tracing in remote prover (#1230)
4e800a3 
* feat: distributed tracing in remote prover

* review: update tracing warning

(cherry picked from commit 59d9016)
@SantiagoPittella
fix: predefine otel.name field with empty value (#1264)
f7b1ac5 
* fix: predefine otel.name field with empty value

* review: remove service.uri, re-add service and method

(cherry picked from commit 5758a0b)
@SantiagoPittella
fix: correct service and method retreival (#1265)
117c4f5 
(cherry picked from commit 01b5b0b)
@SantiagoPittella SantiagoPittella force-pushed the santiagopittella-fix-spans-main branch from b077de9 to 117c4f5 Compare October 7, 2025 21:54
@SantiagoPittella
Copy link
Collaborator Author

SantiagoPittella commented Oct 7, 2025

These are mainly changes from #1230, right? If so, would it make more sense to cherry pick the commit instead of creating a new one? This way you'd avoid (I think) the conflicts and the merge back to next later

Done!

@SantiagoPittella SantiagoPittella added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Oct 7, 2025
bobbinth
bobbinth approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very light review from me - but looks good! Thank you!

Should we release/deploy the new node version after this is merged?

@bobbinth bobbinth merged commit 6bfefc8 into main Oct 9, 2025
6 of 7 checks passed
@bobbinth bobbinth deleted the santiagopittella-fix-spans-main branch October 9, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igamigo igamigo igamigo approved these changes

@bobbinth bobbinth bobbinth approved these changes

@sergerad sergerad sergerad approved these changes

Assignees

No one assigned

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SantiagoPittella @igamigo @bobbinth @sergerad