feat: Implement DataStore:: get_note_script() for NtxDataStore#1332
Merged
feat: Implement DataStore:: get_note_script() for NtxDataStore#1332
Conversation
bobbinth
reviewed
Nov 4, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you. I left some comments inline - but the general approach is along the lines of what I was thinking.
| /// | ||
| /// Each cached script contains the deserialized `NoteScript` object, so the actual memory usage | ||
| /// depends on the complexity of the scripts being cached. | ||
| const DEFAULT_SCRIPT_CACHE_SIZE: usize = 1000; |
Contributor
There was a problem hiding this comment.
This is fine for now, but we should make this a config parameter in the future. Let's create an issue for this.
bobbinth
reviewed
Nov 4, 2025
drahnr
reviewed
Nov 4, 2025
drahnr
reviewed
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #1290.
The
NtxDataStoredoes not currently have an implementation forDataStore::get_note_script().It can be implemented by using the
GetNoteScriptByRootRPC endpoint.Changes
DataStore::get_note_script()forNtxDataStoreusing the RPC.NtxDataStore.