Skip to content

chore: rename ProxyWorkerStatus::address to name#1348

Merged
SantiagoPittella merged 1 commit intonextfrom
santiagopittella-rename-proxyworkerstatus-address
Nov 11, 2025
Merged

chore: rename ProxyWorkerStatus::address to name#1348
SantiagoPittella merged 1 commit intonextfrom
santiagopittella-rename-proxyworkerstatus-address

Conversation

@SantiagoPittella
Copy link
Collaborator

closes #1325

@SantiagoPittella SantiagoPittella force-pushed the santiagopittella-rename-proxyworkerstatus-address branch from dd1a642 to 32c3656 Compare November 10, 2025 15:40
Copy link
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pure rename which may be okay, but I'm unsure if this fulfills the request because it was a bit light on why this is wanted.

@dmitriyselivanov was the requirement with #1325 to configure a name for a worker, or simply to rename the protobuf field from address to name?

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

This is a pure rename which may be okay, but I'm unsure if this fulfills the request because it was a bit light on why this is wanted.

@dmitriyselivanov was the requirement with #1325 to configure a name for a worker, or simply to rename the protobuf field from address to name?

This was intended to be a simple rename. The main idea is that it is up to the proxy to name the worksers. In our implementation, we use IP addresses, but in other implementations, something else could be used.

For example, in @dmitriyselivanov & team's implementation, they could use AWS instance names for workers rather API address (in this scenario, the prover binary is used only to run workers, and there is a separate proxy implementation).

@SantiagoPittella SantiagoPittella merged commit 704dbae into next Nov 11, 2025
6 checks passed
@SantiagoPittella SantiagoPittella deleted the santiagopittella-rename-proxyworkerstatus-address branch November 11, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename ProxyWorkerStatus::address

3 participants