chore: rename ProxyWorkerStatus::address to name#1348
Conversation
dd1a642 to
32c3656
Compare
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
This is a pure rename which may be okay, but I'm unsure if this fulfills the request because it was a bit light on why this is wanted.
@dmitriyselivanov was the requirement with #1325 to configure a name for a worker, or simply to rename the protobuf field from address to name?
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
This is a pure rename which may be okay, but I'm unsure if this fulfills the request because it was a bit light on why this is wanted.
@dmitriyselivanov was the requirement with #1325 to configure a name for a worker, or simply to rename the protobuf field from address to name?
This was intended to be a simple rename. The main idea is that it is up to the proxy to name the worksers. In our implementation, we use IP addresses, but in other implementations, something else could be used.
For example, in @dmitriyselivanov & team's implementation, they could use AWS instance names for workers rather API address (in this scenario, the prover binary is used only to run workers, and there is a separate proxy implementation).
closes #1325