chore(breaking): sync transactions follow ups#1357
Merged
Mirko-von-Leipzig merged 3 commits intonextfrom Nov 17, 2025
Merged
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-sync-transactions-followups
branch
from
7360fa5 to
a94b6d7
Compare
SantiagoPittella
requested review from
Mirko-von-Leipzig,
bobbinth and
igamigo
and removed request for
bobbinth
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Code looks good; just the question about whether to inline the note retrieval as part of the original database query.
drahnr
reviewed
Nov 16, 2025
|
|
||
| // Nullifiers of the input notes of the transaction. | ||
| repeated primitives.Digest input_notes = 4; | ||
| repeated primitives.Digest nullifiers = 4; |
Contributor
There was a problem hiding this comment.
Thank you ❤️ There's nothing like getting confused by a good old misnomer.
drahnr
approved these changes
Nov 16, 2025
Mirko-von-Leipzig
approved these changes
Nov 17, 2025
Mirko-von-Leipzig
deleted the
santiagopittella-sync-transactions-followups
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1258
This PR:
input_notestonullifiersin the transactions table.transaction_records -> transactions,transaction_header -> header.