feat: timeouts for prover clients#1365
Merged
Mirko-von-Leipzig merged 4 commits intomainfrom Nov 14, 2025
Merged
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-make-timeouts-configurable
branch
from
11a3aba to
12bb716
Compare
SantiagoPittella
requested review from
Mirko-von-Leipzig,
bobbinth and
igamigo
Mirko-von-Leipzig
changed the title
Mirko-von-Leipzig
approved these changes
Nov 13, 2025
Collaborator
|
Was the main motivation for this for the network monitor? |
Collaborator
Author
Yesterday, the remote prover was taking between 12 and 15 seconds prove, so the operation was being cancelled by the client because of the 10s timeout. |
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Mirko-von-Leipzig
deleted the
santiagopittella-make-timeouts-configurable
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to the
mainbranchThis PR adds a
with_timeoutmethod for the remote prover clients (Transaction, batch and block) that allows the configuration of the timeout.Also, add a
--request-timeoutconfiguration in the remote prover to set the outgoing requests timeout.