feat(block-producer): detect and abort on chain desync#1520
Merged
Mirko-von-Leipzig merged 3 commits intonextfrom Jan 16, 2026
Merged
feat(block-producer): detect and abort on chain desync#1520Mirko-von-Leipzig merged 3 commits intonextfrom
Mirko-von-Leipzig merged 3 commits intonextfrom
Conversation
4f39b1d to
e519b54
Compare
bobbinth
approved these changes
Jan 16, 2026
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of small comments inline.
3381db3 to
11b8c06
Compare
11b8c06 to
3867476
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This detects situations where the block-producer disagrees with the store on the current chain tip. This should only be possible under rare circumstances, but one possibility is:
N+1to store via gRPCN+1NN+1is now rejected bystoreThere are multiple points to detect this. This code determines by comparing the block number being built against the input's header returned from the
store. The block builder task panics, which should abort the block-producer process.Note that this error isn't really recoverable; and requires a full reset of the block-producer. Aborting and restarting is the easiest way to implement this.
Closes #1513.