Merged
Conversation
…dition fixed (#1508) Fixes several issues: - Race condition in the store's `apply_block` - A request cancellation (e.g. due to timeout from gRPC client) halts the process in some arbitrary location. - Solved by moving the process to a spawned task so it isn't cancelled by the gRPC method. - Ntx builder not adhering to the protocol note limit in the checker - Ntx builder not notes from error'd txs as failed - Improve telemetry more
This enables the trace feature in deadpool which is otherwise disabled by default. This means that tracing hasn't worked inside any of our database interactions since these are passed into deadpool which only passes the span on if trace is enabled.
Mirko-von-Leipzig
force-pushed
the
mirko/merge-main
branch
from
f088b2e to
eb1d9c0
Compare
drahnr
approved these changes
Jan 19, 2026
sergerad
approved these changes
Jan 19, 2026
bobbinth
approved these changes
Jan 19, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left one small question inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges the
mainintonextwhich include thev0.12.7andv0.12.8changes.This was mostly smooth sailing, except the
ntxfixes which were ported manually since the originalv0.12code has been refactored to the actor model. For reference these are the relevant changelog entries: