chore(validator): improve instrumentation#1587
Merged
Conversation
Mirko-von-Leipzig
added
telemetry
Mirko-von-Leipzig
force-pushed
the
mirko/instrument-validator
branch
from
f99819b to
18ae11c
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/instrument-validator
branch
from
18ae11c to
451d4ca
Compare
bobbinth
approved these changes
Jan 23, 2026
| for tx_header in proposed_block.transactions() { | ||
| let tx_id = tx_header.id(); | ||
| if validated_transactions.get(&tx_id).await.is_none() { | ||
| // TODO: LruCache is a poor abstraction since it locks many times. |
Contributor
There was a problem hiding this comment.
We could add a wrapper - something like ScriptCache and provide bulk operations on this struct - to lock the underlying cache only once for such operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more fine grained instrumentation to the validator.
The resulting code is a bit ugly but I didn't want to touch the core code flow. I'd like to try a different approach at the gRPC level but I'll leave that for another time.