fix: load foreign AccountCode on ntx builder#1598
Conversation
igamigo
force-pushed
the
igamigo-fix-ntx-foreign-maststore
branch
from
d59e684 to
4212965
Compare
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
I think this is probably required in any case?
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
Do we need to make the same fix in the validator?
| // Ensure foreign account procedures are available to the executor via the mast store. | ||
| // This assumes the code was not loaded from before | ||
| self.mast_store.load_account_code(account_inputs.code()); |
There was a problem hiding this comment.
I was incorrect before. I thought TransactionBaseHost (in load_foreign_account_code()) but that method just update the procedure index map. Though, I think it is somewhat confusing that TransactionBaseHost also manages a mast_store.
Maybe we should simplify the structure somehow. cc @PhilippGackstatter - maybe we should create an issue about this in miden-base?
No, the validator already loads it (from |
|
Before merging this, would be nice to see if the agglayer flow works correctly with this and #1599 cc @mmagician @partylikeits1983 |
3 participants
No description provided.