Move state-sync related methods to a separate file#1606
Merged
Conversation
bobbinth
added
the
no changelog
bobbinth
commented
Jan 28, 2026
Comment on lines
+39
to
+40
| #[instrument(level = "debug", target = COMPONENT, skip_all, ret(level = "debug"), err)] | ||
| pub async fn sync_notes( |
Contributor
Author
There was a problem hiding this comment.
Some methods here are instrumented, while others are not. I couldn't tell why that's the case - but kept things as they were.
Collaborator
There was a problem hiding this comment.
Yeah some still have them at level=debug which for all purposes means they never get logged in production. We need to figure an approach here still.
Mirko-von-Leipzig
approved these changes
Jan 28, 2026
Collaborator
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Long(er) term it would be nice to move to something like file-per-method implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR moves sync-related methods from the
Statestruct in the store to a separate file. The main motivation is to make themod.rsfile a bit smaller and easier to navigate. No actual code changes were made here.