Skip to content

chore: ~remove~ ignore flaky test re capacity, serialize prove generating tests#1723

Open
drahnr wants to merge 4 commits intonextfrom
bernhard-capacity-test-drop
Open

chore: ~remove~ ignore flaky test re capacity, serialize prove generating tests#1723
drahnr wants to merge 4 commits intonextfrom
bernhard-capacity-test-drop

Conversation

@drahnr
Copy link
Contributor

@drahnr drahnr commented Feb 28, 2026

https://midengroup.slack.com/archives/C08UTTDUMAS/p1772228752145459

The test is failing in CI in various of my PRs, yet I cannot reproduce it locally, nor is the test critical.

@drahnr drahnr added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Feb 28, 2026
Copy link
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The culprit is simply CI performance :/

I suspect what's occurring is that the proving is simply too slow on the CI runner, and that the proof jobs are therefore timing out after 1 minute.

This is the sort of thing where we could "cheat" by using dependency injection to replace the proving with something cheap. However I dislike mocking like that.

Before we merge this, we should see if there are alternatives to improve the CI performance somehow. We already have dev profile optimisations specifically for this -- I wonder if we can go further? Or maybe we do need to mock this.. I kinda like having this test :) Though it isn't critical. The other tests in this file also take 60s+ so it is an issue to address maybe..

@drahnr
Copy link
Contributor Author

drahnr commented Mar 2, 2026

The current CI failure is fixed in #1727

@drahnr drahnr force-pushed the bernhard-capacity-test-drop branch 2 times, most recently from a86470a to c978e1a Compare March 2, 2026 15:11
@drahnr drahnr force-pushed the bernhard-capacity-test-drop branch from c978e1a to 4d2c4cb Compare March 2, 2026 19:42
@drahnr drahnr changed the title chore: remove flaky test re capacity chore: ~remove~ ignore flaky test re capacity, serialize prove generating tests Mar 2, 2026
@drahnr
Copy link
Contributor Author

drahnr commented Mar 2, 2026

I ignored the test that does 3 concurrent proof generation events and added #[serial_test::serial] annotations to the other tests that also request proving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants