chore: remove chain tip from mempool subscription#1771
Merged
Mirko-von-Leipzig merged 3 commits intonextfrom Mar 11, 2026
Merged
chore: remove chain tip from mempool subscription#1771Mirko-von-Leipzig merged 3 commits intonextfrom
Mirko-von-Leipzig merged 3 commits intonextfrom
Conversation
SantiagoPittella
force-pushed
the
santiagopittella-remove-chain-tip-from-mempool-sub
branch
from
9eacc76 to
b8607a2
Compare
| // subscription, if any. | ||
| // Currently only a single active subscription is supported. Subscription requests will cancel | ||
| // the active subscription, if any. | ||
| rpc MempoolSubscription(MempoolSubscriptionRequest) returns (stream MempoolEvent) {} |
Collaborator
There was a problem hiding this comment.
Should we change the request type tp .google.proto.Empty (or whatever that name is)
Collaborator
Author
There was a problem hiding this comment.
Yes, that's better
Mirko-von-Leipzig
approved these changes
Mar 11, 2026
Mirko-von-Leipzig
deleted the
santiagopittella-remove-chain-tip-from-mempool-sub
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1766
Removes chain tip requirement from the mempool subscription.