Skip to content

feat/rocksdb: expose rocksdb config per LargeSmt tree#1782

Merged
drahnr merged 13 commits intonextfrom
bernhard-rocksdb-config-cli-opts-threadin
Mar 12, 2026
Merged

feat/rocksdb: expose rocksdb config per LargeSmt tree#1782
drahnr merged 13 commits intonextfrom
bernhard-rocksdb-config-cli-opts-threadin

Conversation

@drahnr
Copy link
Contributor

@drahnr drahnr commented Mar 11, 2026

As per discussion, lowers the default number of max open file descriptors to 64 from 512 per isntance and exposes them for host specific tuning.

There's a bit of boilerplate due to the conditional rocksdb feature gating.

Ref #1776

@drahnr drahnr changed the title feat: expose rocksdb config per tree feat/rocksdb: expose rocksdb config per LargeSmt tree Mar 11, 2026
Copy link
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sad that a tech choice is leaking into our config and that there isn't a sensible default one can set and forget.

I wonder if we shouldn't instead have a single performance cfg low | high etc. Or maybe a warning log if ulimit is set too low..

@drahnr drahnr merged commit e38509c into next Mar 12, 2026
19 checks passed
@drahnr drahnr deleted the bernhard-rocksdb-config-cli-opts-threadin branch March 12, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants