revert: remove stress-test seeding offset changes#1829
Conversation
The index offset separation and StdRng-based seed generation were introduced to avoid account ID prefix collisions, but the stress test passes without them. Revert to the simpler original logic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Maybe to note that we need this to work with millions of accounts as well. So collisions are maybe possible? |
Yes we might end up with some collisions w.h.p. for large account numbers. This PR only reverts the changes introduced (by confusion in the other PR to keep the diff there relevant). Are you suggesting to keep the changes? If so, I'd maybe leave this for a follow-up, where we also adapt the stress test in CI? |
Ah, I wasn't aware of the context :) Was just saying that 500 accounts isn't sufficient to be sure :D Happy to merge this then. |
44c1a68
into
mmagician-claude/update-base-to-beta
Summary
pub_offset/priv_offset) and high-entropyStdRng-based seed generation in the stress test seedingblock_num * num_accounts + account_indexindexing andindex.to_be_bytes()seed generationThese changes were introduced to avoid account ID prefix collisions, but the stress test passes without them (verified locally with
seed-store --num-accounts 500 --public-accounts-percentage 50).Test plan
seed-storepasses locally without these changes🤖 Generated with Claude Code