Conversation
Mirko-von-Leipzig
approved these changes
Mar 31, 2026
SantiagoPittella
approved these changes
Mar 31, 2026
sergerad
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running web client integration tests locally revealed
TypeError: Failed to fetcherrors on some network calls, which was strange because the rate limiting was being honored at the gRPC client level; also we were not receiving the expected 429/ResourceExhausted(gRPC error code wasUnknown). This wasn't happening in the CI so it did seem like a concurrency/node load problem.It was CORS again! Sort of, at least. The message was not being translated correctly and it appeared as a CORS problem, so moved the layer ordering around and it worked out.
Ideally this would be tested but it did not seem trivial to add here.