Skip to content

feat: generalize get_network_note_status endpoint#1892

Merged
SantiagoPittella merged 15 commits intonextfrom
santiagopittella-generalize-get-network-note-endpoint
Apr 16, 2026
Merged

feat: generalize get_network_note_status endpoint#1892
SantiagoPittella merged 15 commits intonextfrom
santiagopittella-generalize-get-network-note-endpoint

Conversation

@SantiagoPittella
Copy link
Copy Markdown
Collaborator

closes #1818

Renames GetNoteError to GetNetworkNoteStatus and extend the endpoint to return the full lifecycle status of a network note (Pending, Processed, Discarded, Committed).

@SantiagoPittella SantiagoPittella force-pushed the santiagopittella-generalize-get-network-note-endpoint branch from b1b5722 to e5d3b3b Compare April 6, 2026 15:07
Copy link
Copy Markdown
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few small comments inline.

Comment thread CHANGELOG.md Outdated
Comment thread proto/proto/internal/ntx_builder.proto
Comment thread docs/external/src/rpc.md Outdated
Comment thread proto/proto/rpc.proto Outdated
@SantiagoPittella SantiagoPittella merged commit 74e2009 into next Apr 16, 2026
19 checks passed
@SantiagoPittella SantiagoPittella deleted the santiagopittella-generalize-get-network-note-endpoint branch April 16, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generalize GetNoteError endopint

4 participants