Skip to content

rpc/store: align list-limit metadata and document query limits#1985

Closed
namedfarouk wants to merge 2 commits into0xMiden:nextfrom
namedfarouk:codex/issue-1080-rpc-limit-docs
Closed

rpc/store: align list-limit metadata and document query limits#1985
namedfarouk wants to merge 2 commits into0xMiden:nextfrom
namedfarouk:codex/issue-1080-rpc-limit-docs

Conversation

@namedfarouk
Copy link
Copy Markdown

@namedfarouk namedfarouk commented Apr 22, 2026

Summary

  • align SyncNullifiers list-limit validation in RPC and store with the parameter semantics (nullifier_prefix)
  • expose the same SyncNullifiers parameter key via GetLimits
  • extend GetLimits test coverage to assert SyncNullifiers and SyncNotes limits
  • expand internal RPC docs with a concrete query-limits table and rationale

Why

Issue #1080 asks to revisit/document list parameter limits.

This keeps limit handling consistent across:

  • runtime validation
  • GetLimits response metadata
  • tests
  • internal docs

Validation

  • cargo test -p miden-node-rpc get_limits_endpoint
  • cargo check -p miden-node-store -p miden-node-rpc

Closes #1080

@namedfarouk
Copy link
Copy Markdown
Author

Superseded by #1986 (same changes on a clean branch name + issue assignment request flow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit limits for list parameters in proto messages

1 participant