Skip to content

ci: add shear, workspace inheritance, and zizmor checks, and move heavy GitHub Actions jobs to WarpBuild#2013

Merged
huitseeker merged 5 commits intonextfrom
ci-cargo-shear-zizmor-warpbuild-node
Apr 30, 2026
Merged

ci: add shear, workspace inheritance, and zizmor checks, and move heavy GitHub Actions jobs to WarpBuild#2013
huitseeker merged 5 commits intonextfrom
ci-cargo-shear-zizmor-warpbuild-node

Conversation

@huitseeker
Copy link
Copy Markdown
Contributor

@huitseeker huitseeker commented Apr 29, 2026

This adds three CI checks for repo health. cargo-shear checks for unused or misplaced Rust dependencies. zizmor checks GitHub Actions files for unsafe patterns. cargo-workspace-inheritance-check makes shared dependencies use one workspace entry.

Heavy Rust jobs now run on WarpBuild runners to reduce CI time (tests: 18m -> 8m). The PR also pins Actions more tightly, removes unused dependencies found by cargo-shear, and keeps workspace dependency versions centralized.

@huitseeker huitseeker added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Apr 29, 2026
@huitseeker huitseeker marked this pull request as ready for review April 29, 2026 01:58
@huitseeker huitseeker requested a review from sergerad April 29, 2026 01:58
Comment thread crates/rpc/src/tests.rs
Err(err) => return Err(err),
}
}
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if 30 attempts with 200ms is what we want here.

Copy link
Copy Markdown
Collaborator

@sergerad sergerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just wondering about the retry logic added, commented inline.

Comment thread .github/actions/debian/action.yml
Comment thread .github/workflows/cleanup-workflows.yml
Comment thread .github/workflows/cleanup-workflows.yml Outdated
Comment thread .github/workflows/cleanup-workflows.yml
Comment thread crates/db/Cargo.toml Outdated
Comment thread Cargo.toml
Copy link
Copy Markdown
Collaborator

@sergerad sergerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the Debian workflows which seemed to fail. Created a v0.0.0-test.1 tag for this branch's latest commit.

https://github.com/0xMiden/node/actions/runs/25092885824

Comment thread .github/workflows/ci.yml
@huitseeker
Copy link
Copy Markdown
Contributor Author

@sergerad Indeed, one fix was needed in this branch: tag refs must be peeled to commits before using them with git show "$sha:path".

Comment thread .github/actions/debian/action.yml
Copy link
Copy Markdown
Collaborator

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sergerad
Copy link
Copy Markdown
Collaborator

@sergerad Indeed, one fix was needed in this branch: tag refs must be peeled to commits before using them with git show "$sha:path".

I updated the tag to your latest commit but still failing https://github.com/0xMiden/node/actions/runs/25145113300

@huitseeker huitseeker force-pushed the ci-cargo-shear-zizmor-warpbuild-node branch from 02eb99c to 0cba4e5 Compare April 30, 2026 15:49
@huitseeker huitseeker force-pushed the ci-cargo-shear-zizmor-warpbuild-node branch from 0cba4e5 to f50b158 Compare April 30, 2026 17:05
@huitseeker
Copy link
Copy Markdown
Contributor Author

@sergerad Docker-tested and passing on my side.

Copy link
Copy Markdown
Collaborator

@sergerad sergerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM TY.

Debian release worked until the point of where the Github release is expected to exist 👍
https://github.com/0xMiden/node/actions/runs/25192465857

@huitseeker huitseeker merged commit 909de78 into next Apr 30, 2026
19 of 25 checks passed
@huitseeker huitseeker deleted the ci-cargo-shear-zizmor-warpbuild-node branch April 30, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog This PR does not require an entry in the `CHANGELOG.md` file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants