refactor(lru_cache): simplify locking in LRU cache wrapper#2015
Merged
refactor(lru_cache): simplify locking in LRU cache wrapper#2015
Conversation
The API explicitly guarantees that the lock cannot be held across await points, so we can simplify the implementation by removing the async mutex and using a standard mutex instead.
kkovaacs
added
the
no changelog
Mirko-von-Leipzig
approved these changes
Apr 29, 2026
sergerad
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API explicitly guarantees that the lock cannot be held across await points, so we can simplify the implementation by removing the async mutex and using a standard mutex instead.
See the Tokio documentation for a more detailed reasoning why a sync mutex should be used here.