fix(proto/build): ignore rustfmt errors when formatting generated code#2018
Merged
Mirko-von-Leipzig merged 2 commits intonextfrom Apr 30, 2026
Merged
Conversation
The `rustfmt` binary is part of the Rust toolchain even if the `rustfmt` component is not installed, and it will print a warning and exit with status code 1. We can safely ignore rustfmt errors when formatting generated code, as the formatting there only for better readability.
kkovaacs
added
the
no changelog
Mirko-von-Leipzig
approved these changes
Apr 29, 2026
sergerad
approved these changes
Apr 29, 2026
Collaborator
sergerad
left a comment
sergerad
left a comment
There was a problem hiding this comment.
Part of me would rather keep the requirement of rustfmt'ing generated code
Collaborator
Sure but its only for when one would read it -- so if you're developing you already have it. Its only a skip for things like binary builds on machines or docker environments, in case they don't have it installed (which apparently does happen with our toolchain settings?). |
Mirko-von-Leipzig
deleted the
krisztian/fix-docker-build-requiring-rustfmt
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rustfmtbinary is part of the Rust toolchain even if therustfmtcomponent is not installed, and it will print a warning and exit with status code 1.We can safely ignore rustfmt errors when formatting generated code, as the formatting there only for better readability.