feat: remove BlockSigner trait#2057
Merged
Mirko-von-Leipzig merged 1 commit intomainfrom May 7, 2026
Merged
Conversation
Mirko-von-Leipzig
added
the
no changelog
Mirko-von-Leipzig
force-pushed
the
mirko/deasync-signer
branch
2 times, most recently
from
b988fa6 to
7e47850
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/deasync-signer
branch
from
7e47850 to
8a1b84a
Compare
kkovaacs
approved these changes
May 6, 2026
Contributor
kkovaacs
left a comment
kkovaacs
left a comment
There was a problem hiding this comment.
Cool, looks much better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlockSigner::signis an async trait function which abstracts over both KMS and local signing. Unfortunately this also hides the fact local signing is a blocking call happening in an async runtime.#2041 patched over this by hiding in another inner runtime. This PR sidesteps the problem entirely by instead removing the abstraction layer.