chore: block subscription, deactivate actors#2120
Conversation
4e84942 to
3e73be1
Compare
3e73be1 to
46170b5
Compare
46170b5 to
8da5828
Compare
|
Would it make sense to build this on top of #2095 considering #2095 (review)? |
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
This lgtm, some minor comments. Ideally this would include the store -> rpc gRPC service change since the former may or may no longer exist when this merges.
| let block_from = stored_chain_state | ||
| .as_ref() | ||
| .map_or(BlockNumber::GENESIS, |(num, ..)| num.child()); |
There was a problem hiding this comment.
I think we can simplify the logic if we separate out the "bootstrapping" such that we always have at least the genesis block in the database. Similar to how the current store is bootstrapped.
But we can do that in a follow-up.
I've actually come to the conclusion that merging this one first may resolve a lot of the questions people have by virtue of removing the network account stuff. |
|
@SantiagoPittella I've made the following changes to unblock and move other PRs along,
|
This PR:
is_syncedto true when reached, after that it cointinues fetching and updating the local tip.Caution
This change halts the execution of network transactions