ci: switch docker builds to warp#2128
Merged
Merged
Conversation
Mirko-von-Leipzig
added
no changelog
kkovaacs
reviewed
May 25, 2026
Contributor
kkovaacs
left a comment
kkovaacs
left a comment
There was a problem hiding this comment.
The Docker build changes look good to me, but please remove the unrelated changes.
added 6 commits
May 25, 2026 09:18
Comment on lines
+34
to
+36
| RUN --mount=type=cache,sharing=locked,target=/usr/local/cargo/registry \ | ||
| --mount=type=cache,sharing=locked,target=/usr/local/cargo/git/db \ | ||
| --mount=type=cache,sharing=locked,target=/app/target \ |
Collaborator
Author
There was a problem hiding this comment.
I'm hoping this improves the minor dependency change caching..
Collaborator
Author
There was a problem hiding this comment.
This does mean each of our three builds blocks the other in the caching layer, but since its the same build (largely), I think this is fine?
Comment on lines
-79
to
-80
| cache-from: type=s3,region=${{ secrets.AWS_REGION }},bucket=${{ secrets.AWS_CACHE_BUCKET }},name=miden-${{ matrix.component }} | ||
| cache-to: type=s3,region=${{ secrets.AWS_REGION }},bucket=${{ secrets.AWS_CACHE_BUCKET }},name=miden-${{ matrix.component }},mode=max |
Collaborator
Author
There was a problem hiding this comment.
I removed this because warp has its own cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title.
This should speed up the slowest part of our CI.
Note:
env.WARPBUILD_DOCKER_BUILDER_PROFILEin repo settingswarpdocker builds automatically cache layers (source)