fix(store/genesis): use Smt to compute account root of genesis block#2151
Merged
Conversation
`LargeSmt` is pretty expensive to construct and since the account tree in the genesis block is not expected to be huge we can safely avoid that initialization cost by simply using `Smt` instead of `LargeSmt`.
Mirko-von-Leipzig
approved these changes
May 28, 2026
Collaborator
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Oh that's neat.
bobbinth
approved these changes
May 28, 2026
Contributor
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
Is there a noticeable difference for how fast the tests run with this?
Contributor
Author
Yes. For example, running all tests for the validator on my laptop before the change: After the change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LargeSmtis pretty expensive to construct and since the account tree in the genesis block is not expected to be huge we can safely avoid that initialization cost by simply usingSmtinstead ofLargeSmt.