refactor(store): move sync and proving to block producer#2155
Merged
Conversation
Mirko-von-Leipzig
added
the
no changelog
sergerad
reviewed
May 29, 2026
| max_txs_per_batch: self.block_producer.batch.max_txs, | ||
| max_batches_per_block: self.block_producer.block.max_batches, | ||
| max_concurrent_proofs: self.block_producer.block.max_concurrent_proofs, | ||
| mempool_tx_capacity: self.block_producer.mempool.tx_capacity, |
Collaborator
There was a problem hiding this comment.
nit: Maybe the self.block_producer and Sequencer could use the same struct for these shared fields?
Collaborator
Author
There was a problem hiding this comment.
I'm not quite sure how, unless you mean the block producer should own the clap representation directly?
I'd prefer not to do that since how we organise the CLI isn't necessarily how things work in the block producer, so I don't want to couple them.
Or put differently, ideally we would keep the code type separate from the interface boundary, in this case the CLI API.
sergerad
reviewed
May 29, 2026
sergerad
reviewed
May 29, 2026
sergerad
reviewed
May 29, 2026
sergerad
reviewed
May 29, 2026
sergerad
reviewed
May 29, 2026
sergerad
approved these changes
May 29, 2026
Collaborator
sergerad
left a comment
sergerad
left a comment
There was a problem hiding this comment.
LGTM just a nit and some dedupe we should be able to do in the comments.
SantiagoPittella
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the replica sync and proof scheduling to the block-producer.
This leaves
storeas 99%Statemanagement, with no spawned tasks outside of the disk monitor which will be invoked manually by the CLI.I've also added a name-task
JoinSetwrapper for supervising tasks - this is fairly common across the code base.I elected to this now because I found it made wiring up the CLI much easier since the store no longer has spawned tasks internally.