chore: make next compatible with protocol v0.15.2 network-account changes#2205
Merged
Mirko-von-Leipzig merged 5 commits intoJun 5, 2026
Merged
Conversation
…nges Adapts the node to the network-account tx-script allowlist landed in 0xMiden/protocol#3028 (shipping in v0.15.2): - Bump miden-* deps to 0.15.2. - Rename AuthNetworkAccount::with_allowlist -> with_allowed_notes call sites (protocol#3049). The ntx-builder expiration tx script stays disabled: re-enabling it is gated on a canonical, frozen expiration script (protocol#3050) whose root every serviced network account (including the AggLayer bridge/faucets) can allowlist. Comments updated to reflect this; counter-account deploy carries a TODO for the allowlisting it will need on re-enable. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mirko-von-Leipzig
approved these changes
Jun 5, 2026
Mirko-von-Leipzig
deleted the
partylikeits1983-claude/ntx-tx-script-allowlist-compat
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft / blocked on the protocol v0.15.2 release. Prepared ahead of time so
nextcan flip green the moment v0.15.2 is published (see protocol#3028 follow-up request).What this does
miden-*deps to0.15.2.AuthNetworkAccount::with_allowlist->with_allowed_notesat all call sites, tracking the protocol rename in protocol#3049.What this deliberately does NOT do
The ntx-builder's expiration tx script stays disabled. The mechanism to run allowlisted tx scripts on network accounts has landed (protocol#3028, resolving #3027), but re-enabling here is gated on a canonical, frozen expiration script in
miden-standards(protocol#3050).Re-enabling now would attach the script to every network tx, and every serviced network account - including the protocol-created AggLayer bridge and faucets, which allowlist notes but no tx scripts - would have its transactions rejected by the new tx-script allowlist. The canonical script gives all account creators one shared root to pin. Comments in
execute.rsand a TODO at the counter-account deploy site capture the re-enable follow-up.Verification
Built and tested locally against
protocolmain+ #3049 via a temporary[patch.crates-io](not committed):cargo build -p miden-ntx-builder -p miden-network-monitorcargo test -p miden-ntx-builder -p miden-network-monitor(all passed, incl.expiration_script_compiles_and_encodes_delta)CI will stay red until
miden-* 0.15.2is on crates.io.🤖 Generated with Claude Code