Conversation
Mirko-von-Leipzig
approved these changes
Oct 21, 2024
Collaborator
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
I think this is good improvement.
There are still possibilities where the mapping might be the wrong default for some situations; e.g. if we have bad internal state and attempt to retrieve an unknown block then that shouldn't be exposed.
Though I think this will always remain the case; and this PR at least restrains the default non-internal mappings to a smaller set.
Contributor
Author
Yes, for such cases we can map it to whatever we need. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we improve error statuses returned by the some store API.
Initially it was needed by #504 (I wanted to be able to process "account not in DB" errors), but finally it became unused due to changed solution. But it might make our API better, so I propose to keep these changes.