Merged
Conversation
Mirko-von-Leipzig
force-pushed
the
mirko/otel
branch
from
d9c2712 to
9f31dc1
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/otel
branch
2 times, most recently
from
62f777a to
71f1e33
Compare
Mirko-von-Leipzig
changed the title
Mirko-von-Leipzig
force-pushed
the
mirko/otel
branch
from
71f1e33 to
f0f8b41
Compare
bobbinth
approved these changes
Jan 31, 2025
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of small comments inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
--open-telemetryflag to the node'sstartcommand. This exports traces to an open-telemetry backend.The various settings of this exporter can be controlled by the various environment variables specified by the standard e.g.
sets the target endpoint.
This is just initial support for this; our actual traces are still very non-conforming to the standard.