refactor: migrate to diesel-rs for query construction#928
Merged
Conversation
ec1d97d to
4f94df1
Compare
bobbinth
reviewed
Jun 7, 2025
bobbinth
reviewed
Jun 7, 2025
fae3879 to
39ea14d
Compare
b4b6fd7 to
e4c3ee5
Compare
diesel-rs for query construction
e4c3ee5 to
ed19245
Compare
sergerad
reviewed
Jul 22, 2025
Contributor
Author
|
Let's have a call on Monday post our regular calls and sync up then @sergerad @Mirko-von-Leipzig |
This reverts commit 101f24c.
1dca38f to
b5d7dca
Compare
Mirko-von-Leipzig
approved these changes
Jul 29, 2025
Collaborator
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
Couple of questions but I think we should proceed with this before we damage it (and its authors) health any more :D
drahnr
commented
Jul 29, 2025
bobbinth
reviewed
Jul 30, 2025
bobbinth
reviewed
Jul 30, 2025
bobbinth
reviewed
Jul 30, 2025
bobbinth
reviewed
Jul 30, 2025
bobbinth
reviewed
Jul 30, 2025
bobbinth
reviewed
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A example of using
diesel.rsas an ORM for a single query.Learnings
Caveats
models.rsneed to align precisely with the schema generated from the database inschema.rs- otherwise one gets lengthy errors - but at least at compile timeUpsides
Outstanding
Closes #921