feat: add `.is_network_note()` helper method for `Note` by partylikeits1983 · Pull Request #2365 · 0xMiden/protocol

partylikeits1983 · 2026-01-29T00:12:31Z

This PR adds a new NetworkNote type which makes it easy to determine if a Note is a network note or not.

Resolves: #2362

crates/miden-standards/src/note/network_note.rs

Copilot

Pull request overview

This PR introduces a new AccountTargetNetworkNote type and NetworkNoteExt trait to make it easier to determine if a Note is a network note and to access network-specific properties. This addresses issue #2362 by providing a cleaner, more discoverable API compared to the previous approach of using NetworkAccountTarget::try_from(note.metadata().attachment()).

Changes:

Added AccountTargetNetworkNote<'a> struct providing a view over notes with NetworkAccountTarget attachments
Added NetworkNoteExt trait with is_network_note() and as_account_target_network_note() convenience methods
Added integration test test_network_note_unwrap() verifying the new API works correctly

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
crates/miden-standards/src/note/network_note.rs	New module defining `AccountTargetNetworkNote` struct and `NetworkNoteExt` trait for working with network notes
crates/miden-standards/src/note/mod.rs	Exports the new `AccountTargetNetworkNote` and `NetworkNoteExt` types
crates/miden-testing/src/kernel_tests/tx/test_output_note.rs	Adds integration test verifying the new network note API
CHANGELOG.md	Documents the addition of the NetworkNote type in release 0.14.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/miden-standards/src/note/network_note.rs

crates/miden-testing/src/kernel_tests/tx/test_output_note.rs

CHANGELOG.md

crates/miden-standards/src/note/network_note.rs

PhilippGackstatter

Looks good to me! Sorry for the delay!

Left a small comment re usability of this type in the node. I think copilot makes some good points as well.

PhilippGackstatter · 2026-02-25T13:09:35Z

crates/miden-standards/src/note/network_note.rs

+pub struct AccountTargetNetworkNote<'a> {
+    note: &'a Note,


I'd probably make this own the underlying note and provide unwrap functionality like AccountTargetNetworkNote::into_note(self) -> Note and AccountTargetNetworkNote::as_note(&self) -> &Note. NetworkNoteExt::as_account_target_network_note would become into_*.
I think without this the node would probably not be able to use the wrapper (and maybe that's fine?) cc @Mirko-von-Leipzig @sergerad .

Agreed - I think wrapping a full note (rather than just a reference) would make this more flexible. AFAIK, it most relevant contexts, we'd be converting a Note into AccountTargetNetworkNote. But also, if that's not the case, cloning here wouldn't be too bad either (and if we do want to avoid cloning, using Arc could be a better option).

crates/miden-standards/src/note/network_note.rs

bobbinth

Looks good! Thank you! I left a couple of comments inline.

bobbinth · 2026-02-25T20:02:12Z

crates/miden-standards/src/note/network_note.rs

+pub struct AccountTargetNetworkNote<'a> {
+    note: &'a Note,


Agreed - I think wrapping a full note (rather than just a reference) would make this more flexible. AFAIK, it most relevant contexts, we'd be converting a Note into AccountTargetNetworkNote. But also, if that's not the case, cloning here wouldn't be too bad either (and if we do want to avoid cloning, using Arc could be a better option).

bobbinth · 2026-02-25T20:03:52Z

crates/miden-standards/src/note/network_note.rs

+/// other types of network notes may exist (e.g., SWAP notes that can be consumed by network
+/// accounts but are not targeted at a specific one).
+#[derive(Clone, Debug, PartialEq, Eq)]
+pub struct AccountTargetNetworkNote<'a> {


I don't love the name AccountTargetNetworkNote, but also don't have much better suggestions. Maybe something like AccountBoundNetworkNote?

Do you think SingleTargetNetworkNote is a better name? As @PhilippGackstatter wrote above, we will later on have network notes which could theoretically be filled by multiple network accounts (although not sure how that would work, but that is a separate discussion).

…nt accessor

partylikeits1983 · 2026-02-27T14:56:54Z

@PhilippGackstatter @bobbinth I addressed all of your comments: AccountTargetNetworkNote now owns the Note with into_note()/as_note() accessors, added execution_hint() convenience method, and updated tests accordingly.

Although already approved, would appreciate one more quick round of review to verify updates, and to think about potentially a better name for AccountTargetNetworkNote, as outlined in this thread: #2365 (comment)

If everything looks good, feel free to merge!

bobbinth

All looks good! Thank you!

I do slightly prefer AccountBoundNetworkNote - but I wouldn't make the change in this PR. Let's open an issue to discuss potential name changes.

PhilippGackstatter

Thank you, looks great!

feat: implement NetworkNote type

c1aea73

partylikeits1983 force-pushed the ajl-network-note-newtype branch from 3b1b042 to c1aea73 Compare January 29, 2026 01:03

chore: add changelog

25a1c08

partylikeits1983 requested a review from PhilippGackstatter January 29, 2026 01:05

partylikeits1983 marked this pull request as ready for review January 29, 2026 01:05

PhilippGackstatter reviewed Jan 29, 2026

View reviewed changes

crates/miden-standards/src/note/network_note.rs Outdated Show resolved Hide resolved

crates/miden-standards/src/note/network_note.rs Outdated Show resolved Hide resolved

igamigo reviewed Jan 29, 2026

View reviewed changes

crates/miden-standards/src/note/network_note.rs Outdated Show resolved Hide resolved

crates/miden-standards/src/note/network_note.rs Outdated Show resolved Hide resolved

partylikeits1983 marked this pull request as draft January 29, 2026 15:07

mmagician added the pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority label Feb 9, 2026

partylikeits1983 added 2 commits February 19, 2026 00:20

chore: merge next

3ab11bf

refactor: simplify NetworkNote error handling and optimize

edf5d44

partylikeits1983 marked this pull request as ready for review February 18, 2026 21:46

partylikeits1983 requested a review from PhilippGackstatter February 18, 2026 21:46

partylikeits1983 added 2 commits February 20, 2026 19:39

refactor: rename NetworkNote to AccountTargetNetworkNote

440ff7c

Merge branch 'next' into ajl-network-note-newtype

abdb131

partylikeits1983 requested a review from Copilot February 20, 2026 16:44

Copilot started reviewing on behalf of partylikeits1983 February 20, 2026 16:44 View session

chore: update changelog entry

f6c9255

Copilot AI reviewed Feb 20, 2026

View reviewed changes

crates/miden-standards/src/note/network_note.rs Show resolved Hide resolved

crates/miden-testing/src/kernel_tests/tx/test_output_note.rs Show resolved Hide resolved

CHANGELOG.md Show resolved Hide resolved

crates/miden-standards/src/note/network_note.rs Show resolved Hide resolved

partylikeits1983 changed the title ~~feat: implement NetworkNote newtype~~ feat: add .is_network_note() helper method for Note Feb 20, 2026

Merge branch 'next' into ajl-network-note-newtype

6f35372

PhilippGackstatter approved these changes Feb 25, 2026

View reviewed changes

Merge branch 'next' into ajl-network-note-newtype

9de7096

bobbinth approved these changes Feb 25, 2026

View reviewed changes

partylikeits1983 added 2 commits February 27, 2026 17:50

refactor: make AccountTargetNetworkNote own Note and add execution_hi…

c103390

…nt accessor

Merge remote-tracking branch 'origin/next' into ajl-network-note-newtype

f40c4c6

test: expand network note test to cover invalid cases and TryFrom

2b06123

bobbinth approved these changes Feb 27, 2026

View reviewed changes

Merge branch 'next' into ajl-network-note-newtype

38f711f

refactor: enforce network notes must be public

14a932c

partylikeits1983 changed the base branch from next to agglayer March 2, 2026 11:09

partylikeits1983 changed the base branch from agglayer to next March 2, 2026 11:10

PhilippGackstatter approved these changes Mar 2, 2026

View reviewed changes

PhilippGackstatter merged commit 592fcbe into next Mar 2, 2026
17 checks passed

PhilippGackstatter deleted the ajl-network-note-newtype branch March 2, 2026 12:23

partylikeits1983 mentioned this pull request Mar 2, 2026

Consider renaming options for AccountTargetNetworkNote #2533

Open

This was referenced Mar 2, 2026

Network note missing public details 0xMiden/node#1726

Closed

fix(store): network notes must be public 0xMiden/node#1738

Merged

Conversation

partylikeits1983 commented Jan 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PhilippGackstatter left a comment

Choose a reason for hiding this comment

Uh oh!

PhilippGackstatter Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

bobbinth Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bobbinth left a comment

Choose a reason for hiding this comment

Uh oh!

bobbinth Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

bobbinth Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

partylikeits1983 Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

partylikeits1983 commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bobbinth left a comment

Choose a reason for hiding this comment

Uh oh!

PhilippGackstatter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

partylikeits1983 commented Feb 27, 2026 •

edited

Loading