refactor: use @auth_script MASM attribute instead of auth_ prefix#2534
Merged
refactor: use @auth_script MASM attribute instead of auth_ prefix#2534
@auth_script MASM attribute instead of auth_ prefix#2534Conversation
partylikeits1983
requested review from
PhilippGackstatter,
greenhat and
mmagician
partylikeits1983
added
standards
partylikeits1983
changed the title
@auth_script MASM attribute instead of auth_ prefix@auth_script MASM attribute instead of auth_ prefix
PhilippGackstatter
approved these changes
Mar 2, 2026
Contributor
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me!
If/Once we have an AccountAuthComponent, we should check that it has that attribute, but that's for the future.
mmagician
approved these changes
Mar 2, 2026
Collaborator
mmagician
left a comment
mmagician
left a comment
There was a problem hiding this comment.
LGTM, I'll merge so that we get this into alpha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the convention of detecting authentication procedures by their
auth_name prefix with the@auth_scriptMASM attribute. This is consistent with the existing@note_scriptattribute pattern and follows the naming convention suggested for consistency (auth_script / note_script).Resolves: #2501