Skip to content

feat(agglayer): add CLAIM and B2AGG cycle count benchmarks#2753

Merged
mmagician merged 3 commits intomainfrom
mmagician-claude/squash-pr-2618
Apr 15, 2026
Merged

feat(agglayer): add CLAIM and B2AGG cycle count benchmarks#2753
mmagician merged 3 commits intomainfrom
mmagician-claude/squash-pr-2618

Conversation

@mmagician
Copy link
Copy Markdown
Collaborator

@mmagician mmagician commented Apr 10, 2026

Turns out that #2618 was never merged into main nor next (looking at the commit history, it seems that #2618 was merged into agglayer branch short after agglayer got merged into next).

This is targeting main because then we can also merge in #2752 cleanly, patch release (it's purely an internal perf change) and have max cycle count lowered back to 128k :)

@mmagician mmagician added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Apr 10, 2026
@mmagician mmagician marked this pull request as ready for review April 10, 2026 10:34
@mmagician mmagician requested a review from bobbinth April 10, 2026 10:36
@mmagician mmagician changed the base branch from next to main April 10, 2026 10:36
Add benchmarks for CLAIM note (L1/L2 bridge-in) and B2AGG note
(bridge-out) consumption alongside existing P2ID benchmarks.

- Move shared test vector types and lazy-parsed vectors into
  miden_agglayer::testing module for reuse across tests and benchmarks
- Add benchmark setup functions for CLAIM and B2AGG transactions
- Add cycle count assertions for CLAIM note processing (max 64k cycles)

Co-Authored-By: partylikeits1983 <partylikeits1983@users.noreply.github.com>
@mmagician mmagician force-pushed the mmagician-claude/squash-pr-2618 branch from 90286c5 to 949890c Compare April 10, 2026 10:38
@mmagician mmagician added agglayer PRs or issues related to AggLayer bridging integration pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority benchmarks Improvements to benchmarks labels Apr 13, 2026
Copy link
Copy Markdown
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! (not a detailed review - I'm assuming this is mostly just code copy-over).

@mmagician mmagician enabled auto-merge April 15, 2026 09:25
@mmagician mmagician disabled auto-merge April 15, 2026 09:25
@mmagician mmagician enabled auto-merge (squash) April 15, 2026 09:25
@mmagician mmagician force-pushed the mmagician-claude/squash-pr-2618 branch from 161cbed to 030bd13 Compare April 15, 2026 10:30
@mmagician mmagician merged commit 1c99e41 into main Apr 15, 2026
17 checks passed
@mmagician mmagician deleted the mmagician-claude/squash-pr-2618 branch April 15, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agglayer PRs or issues related to AggLayer bridging integration benchmarks Improvements to benchmarks no changelog This PR does not require an entry in the `CHANGELOG.md` file pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants